Skip to content

style: fix formatting after CI commit #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Jul 31, 2024

Seems like 8e5fa3a broke the formatting.

Seems like 8e5fa3a broke the
formatting.
@gzm0 gzm0 requested a review from a team as a code owner July 31, 2024 10:43
Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: 02a1164

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow
Copy link
Contributor

drwpow commented Jul 31, 2024

Thanks for fixing, but we just need to ignore JSON from linting/formatting. Otherwise npm/pnpm and Biome will be fighting over the formatting of these files

@drwpow
Copy link
Contributor

drwpow commented Aug 1, 2024

Fixed in #1797; just ignored from Biome. Whenever pnpm touches this it’ll reformat it anyway; no sense in linting.

@drwpow drwpow closed this Aug 1, 2024
@gzm0 gzm0 deleted the fix-format branch August 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants